Skip to content

set the current batch to null after releasing it #10908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

set the current batch to null after releasing it #10908

merged 2 commits into from
Sep 11, 2025

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Sep 10, 2025 •
edited
Loading

this silences a bunch of noisy "Aborting batch" log messages

[TRACE] Aborting JDBC batch - [org.example.Language#INSERT]
[TRACE] Aborting JDBC batch - [org.example.Language#INSERT]
[TRACE] Aborting JDBC batch - [org.example.Language#INSERT]
[TRACE] Aborting JDBC batch - [org.example.Language#INSERT]

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

@gavinking
set the current batch to null after releasing it
fc81e64 
this silences a bunch of noisy "Aborting batch" log messages
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Sep 10, 2025 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [fc81e64, 7b4ed96]

› This message was automatically generated.

@gavinking gavinking marked this pull request as ready for review September 10, 2025 16:28
@gavinking gavinking requested a review from sebersole September 10, 2025 16:29
@gavinking
Copy link
Member Author

@sebersole Does this look right to you?

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 10, 2025
View reviewed changes
hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchingBatchFailureTest.java
configuration.setProperty( AvailableSettings.CHECK_NULLABILITY, false );
}

SessionImplementor session;

Check warning

Code scanning / CodeQL

Field masks field in super class Warning test

This field shadows another field called
session
Loading
in a superclass.
sebersole
sebersole approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@sebersole sebersole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me

@gavinking
Copy link
Member Author

OK, thanks, so I'll merge it.

@gavinking gavinking merged commit 9a5d6bb into hibernate:main Sep 11, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebersole sebersole sebersole approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavinking @sebersole